Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: runfiles path fixups to support site specific (e.g. google) imp… #819

Merged
merged 5 commits into from
Apr 24, 2017

Conversation

htuch
Copy link
Member

@htuch htuch commented Apr 22, 2017

…ort.

  • Access source files via {{ test_rundir }} everywhere.

  • Define TEST_RUNDIR, use it to access source files in shell scripts, instead of futzing with
    $TEST_SRCDIR/$TEST_WORKSPACE.

  • Wrap sh_test/cc_tests with sh_test_wrapper.sh and provide the ability to override main for C++
    tests. This allows site specific customizations to the environment, e.g. overriding TEST_RUNDIR.

  • Allow TestEnvironment::exec to support Python execution via symlinks.

  • Some documentation in STYLE.md to capture the conventions.

  • Fix a port dependency in admin_test.

…ort.

* Access source files via {{ test_srcdir }} everywhere.

* Define TEST_RUNDIR, use it to access source files in shell scripts, instead of futzing with
  $TEST_SRCDIR/$TEST_WORKSPACE.

* Wrap sh_test/cc_tests with sh_test_wrapper.sh and provide the ability to override main for C++
  tests. This allows site specific customizations to the environment, e.g. overriding TEST_RUNDIR.

* Allow TestEnvironment::exec to support Python execution via symlinks.

* Some documentation in STYLE.md to capture the conventions.

* Fix a port dependency in admin_test.
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, tiny nit

@@ -1,6 +1,7 @@
#!/bin/bash

set -e
set -x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

del

@mattklein123 mattklein123 merged commit c339fae into envoyproxy:master Apr 24, 2017
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: these translations were graciously written by @XAntonioLuna @sgenius and @gonzalolarralde and published in Lyft Engineering en Español

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: these translations were graciously written by @XAntonioLuna @sgenius and @gonzalolarralde and published in Lyft Engineering en Español

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants